-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add snap/README.md and update README.md #470
Conversation
Could you please review? @badboy-huaqiao @farshidtz @siggiskulason Thanks! |
Signed-off-by: Mengyi <mengyi.wang@canonical.com>
0439dbd
to
cebb575
Compare
Signed-off-by: Mengyi <mengyi.wang@canonical.com>
@MonicaisHer @farshidtz @siggiskulason it looks like jenkins didn't pass the build |
Thanks @badboy-huaqiao, , do you have any idea how to re-trigger the Jenkins pipeline? I had tried force push, didn't work. Also, there is no error appears in the Jenkins, and LF Post Build Actions passed. Seems like it just needs to a re-build. |
@MonicaisHer you can try to modify somewhere of the file you submit and then execute push operation again, but we should contact devops team why not pass, you can send message to them on slack devops channel |
Signed-off-by: Mengyi <mengyi.wang@canonical.com>
@badboy-huaqiao Ok, I did it. The Jenkins is re-triggered now. I also asked on the slack DevOps channel. |
- update installation section in snap/README.md - simplify JWT token section in snap/README.md - simplify edgexfoundry snap section in snap/README.md - update format, images and wording in snap/README.md - simplify snap section in README.md - add two README related images in snap/local/assets Signed-off-by: Mengyi <mengyi.wang@canonical.com>
Signed-off-by: Mengyi <mengyi.wang@canonical.com>
snap/README.md
Outdated
|
||
### Using the edgex-ui snap | ||
|
||
Open your browser [http://localhost:4000](http://localhost:4000/):![img](https://lh5.googleusercontent.com/OzQFePPICpiaMTxEm8cnxaCFn7ageCbLR9J5TpzkGtmRIip-pB02D7H994gKvVS2CTD3YChngX72SGtaLxEVjdC4j9bgYTFCGHvRfzr25i-qIk3UNMprucpPa2oBpgI_W7KZVJ4n) | ||
Open your browser [http://localhost:4000](http://localhost:4000/):![](/home/mengyi/Desktop/EdgeX_14/edgex-ui-go/snap/local/assets/ui-login.jpg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong image path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated this path. This commit you reviewed was out of date.
snap/README.md
Outdated
|
||
Please use the JWT token we generated above to log in the UI homepage:![img](https://lh3.googleusercontent.com/iE5qQKWkpQsBVmjsKDmgcTO6JDc40hbb-3kp7GGJnWDWj2bH4afOFCGW7WSNNIFIMiUtV5x1duCbVAdd6D2hNS49CspfTaToVZaH7aK3I50uHKRPcfAvQ9miZqprrc7Q--ugzAfh) | ||
![](/home/mengyi/Desktop/EdgeX_14/edgex-ui-go/snap/local/assets/ui-homepage.jpg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong image path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated this path. This commit you reviewed was out of date.
@farshidtz @MonicaisHer is it ready? |
* docs: improve instructions * edgexfoundry installation reference * enabling dependencies * service management wrt. current state * docs: fix typos Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Signed-off-by: Mengyi <mengyi.wang@canonical.com>
Signed-off-by: Mengyi <mengyi.wang@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good.
It's probably best to squash and merge.
@farshidtz ok, thanks for your advice, @MonicaisHer it looks like it's ready, will be merged if you think there is no others work need to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @badboy-huaqiao it's ready. |
Signed-off-by: Mengyi mengyi.wang@canonical.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-ui-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
N/A
New Dependency Instructions (If applicable)