Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(snap): Upgrade snap base to core22, upgrade go to 1.20 #599

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

MonicaisHer
Copy link
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-ui-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Successfully passed the edgex-snap-testing suite locally.

New Dependency Instructions (If applicable)

Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
snap/snapcraft.yaml Outdated Show resolved Hide resolved
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@farshidtz farshidtz merged commit 3e872cf into edgexfoundry:EDGEX-400 Apr 25, 2023
farshidtz pushed a commit that referenced this pull request Apr 26, 2023
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@farshidtz
Copy link
Member

Merged into wrong branch. See #600 instead.

A808597949 pushed a commit to A808597949/edgex-ui-go that referenced this pull request Jul 7, 2023
…ndry#600)

Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants