Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fields for Provision Watcher Tab DTO #657

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: Fields for Provision Watcher Tab DTO #657

merged 1 commit into from
Nov 6, 2023

Conversation

jiekechoo
Copy link
Contributor

@jiekechoo jiekechoo commented Nov 6, 2023 •
edited
Loading

Closes: #642

image image

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-ui-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@jiekechoo
fix: Fields for Provision Watcher Tab DTO
f7e57eb 
Closes: edgexfoundry#642
Signed-off-by: Jieke Choo <jiekechoo@gmail.com>
@lenny-goodell
Copy link
Member

recheck

lenny-goodell
lenny-goodell approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 27d7f09 into edgexfoundry:main Nov 6, 2023
3 checks passed
@lenny-goodell lenny-goodell mentioned this pull request Nov 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenny-goodell lenny-goodell lenny-goodell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fields for Provision Watcher Tab don't match the Provision Watcher DTO
2 participants
@jiekechoo @lenny-goodell