Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the vulnerable Archivers "slackin" invite app #167

Closed
5 of 6 tasks
patcon opened this issue Jul 11, 2017 · 7 comments
Closed
5 of 6 tasks

Update the vulnerable Archivers "slackin" invite app #167

patcon opened this issue Jul 11, 2017 · 7 comments

Comments

@patcon
Copy link
Member

patcon commented Jul 11, 2017

There is a vulnerability that can be a huge hassle if spammer discovers our Slack invite form:
http://slackout.github.io/

Basically, it can flood our invites and make us hit an invite quota that will can the form to fail for many real users, in a way that we can't fix without registering a whole new slack and migrating the community :/

cc: @b5

To Do

  • get access to slackin app (on heroku from @b5?)
  • create google captcha api keys for app
  • update the slack code
  • host code in [datatogether?] github org (optional) https://github.com/datatogether/archivers-slack
  • set up auto-deploy from github master branch (optional)
  • add some other people as heroku contributors (optional)

Outstanding Questions

  1. Does this technically fall under DataTogether now? I ask because the Google Captcha API credentials should prob exist under a proper shared brand account, and I'm not sure what that could be now -- happy to use EDGI brand account for now, but also happy to create a "DataTogether" or "Archivers" brand account, pending feedback :)
@b5
Copy link
Member

b5 commented Jul 12, 2017

yo yo just gave you access on heroku @patcon, I have no idea where/if the repo lives on GitHub, maybe git pull from the heroku endpoint, feel free to modify / push to that heroku box as necessary.

@patcon
Copy link
Member Author

patcon commented Jul 12, 2017

Done and done. Turns out the invite app was actually completely different, and I didn't realize until after. but anyhow, we've now got source code here: https://github.com/datatogether/archivers-slack

There are a couple more features:

  • active and total user counts
  • captcha

Things I did:

  • set up google reCAPTCHA
    • sent an invite to co-own the client keys to your personal gmail @b5
  • added this service to the DataTogether access doc

I'll leave this open until I have time to set up and document the auto-deploy to heroku

@patcon
Copy link
Member Author

patcon commented Jul 12, 2017

Actually, auto-deploy doesn't seem right here. I don't want to fork their code just to doc that in our fork's readme, but otherwise, it would be unexpected behaviour -- someone could accidentally break things while pushing to github

@patcon patcon closed this as completed Jul 12, 2017
@b5
Copy link
Member

b5 commented Jul 13, 2017

screen shot 2017-07-12 at 7 28 05 pm

🤔

@patcon
Copy link
Member Author

patcon commented Jul 13, 2017

confuzzled, I'm seeing it work fine at both http and https.
You using a domain besides https://archivers-slack.herokuapp.com/ ?

slack invite form captcha working

@b5
Copy link
Member

b5 commented Jul 13, 2017

oh, there is also url that points to this same thing: http://slack.archivers.space, must be the issue

@patcon
Copy link
Member Author

patcon commented Jul 13, 2017

ah cool! added that one too. tooltip says it could take up to 30 min to take affect. thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants