Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References from CCL rather than ASBIEs (just like we do for ABIEs) #42

Open
nissimsan opened this issue Oct 14, 2020 · 1 comment
Open

Comments

@nissimsan
Copy link
Contributor

image

The trick we do for classes, containing the “layers” in the unece:cefactElementMetadata sections - could that be done for relationships too? Those two relationships are the same, aren’t they?

So, could

    {
      "@id": "unece:includedSupplyChainConsignmentItem",
      "@type": "rdfs:Property",
      "schema:rangeIncludes": "unece:ConsignmentItem",
      "schema:domainIncludes": "unece:Consignment",
      "rdfs:comment": "A consignment item included in this supply chain consignment.",
      "unece:cefactElementMetadata": [
        {
          "@id": "cefact:SupplyChain_Consignment.Included.SupplyChain_ConsignmentItem",
          "@type": "unece:AssociationBIE",
          "unece:cefactUNId": "cefact:UN01004258",
          "unece:cefactBieDomainClass": "cefact:SupplyChain_Consignment.Details",
          "unece:cefactBusinessProcess": "Buy-Ship-Pay",
          "rdfs:comment": "A consignment item included in this supply chain consignment."
        }
      ]
    },

and

    {
      "@id": "unece:includedReferencedSupplyChainConsignmentItem",
      "@type": "rdfs:Property",
      "schema:rangeIncludes": "unece:ConsignmentItem",
      "schema:domainIncludes": "unece:Consignment",
      "rdfs:comment": "A referenced consignment item included in this referenced supply chain consignment.",
      "unece:cefactElementMetadata": [
        {
          "@id": "cefact:Referenced_SupplyChain_Consignment.Included.Referenced_SupplyChain_ConsignmentItem",
          "@type": "unece:AssociationBIE",
          "unece:cefactUNId": "cefact:UN01004048",
          "unece:cefactBieDomainClass": "cefact:Referenced_SupplyChain_Consignment.Details",
          "unece:cefactBusinessProcess": "Buy-Ship-Pay",
          "rdfs:comment": "A referenced consignment item included in this referenced supply chain consignment."
        }
      ]
    },

be joined together into just unece:includedConsignmentItem? Which could then reference unece:includedSupplyChainConsignmentItem and unece:includedReferencedSupplyChainConsignmentItem within its unece:cefactElementMetadata?

In the Excel export, this would be the
UN01004258 ASBIE Included Consignment Item A consignment item included in this supply chain consignment. 0 unbounded Supply Chain_ Consignment. Included. Supply Chain_ Consignment Item
and
UN01004048 ASBIE Included Consignment Item A referenced consignment item included in this referenced supply chain consignment. 0 unbounded Referenced_ Supply Chain_ Consignment. Included. Referenced_ Supply Chain_ Consignment Item

Combined, named from the common Business Name (Included Consignment Item)

@kshychko
Copy link
Contributor

kshychko commented Nov 18, 2020

@nissimsan, I implemented the NDR from this ticket. Could you please check it out and confirm I did it correctly:

https://edi3.org/vocabulary/unece/#includedConsignmentItem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants