Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(annotations): adding ignore underling deletion annotation #39

Merged
merged 5 commits into from
May 25, 2023

Conversation

smileisak
Copy link
Member

@smileisak smileisak commented May 24, 2023

What this PR does / why we need it:

Closes #9

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #9

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • All new and existing tests passed.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

  • CLI change
  • API change
  • UI change
  • configuration schema change
  • behavioral change
  • change in non-functional attributes such as efficiency or availability, availability of a new platform
  • a warning about a deprecation
  • fix of a previous Known Issue
  • fix of a vulnerability (CVE)

No release notes are required for changes to the following:

  • Tests
  • Build infrastructure
  • Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

adding ignore underling deletion annotation

@smileisak smileisak self-assigned this May 24, 2023
@smileisak smileisak added documentation Improvements or additions to documentation go PR that updates go code labels May 25, 2023
@smileisak smileisak merged commit 13f9dba into main May 25, 2023
@smileisak smileisak deleted the issue/9 branch November 18, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation go PR that updates go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add annotation to ignore underlying resource deletion.
1 participant