Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Icons #48

Open
edjonesdev opened this issue Apr 28, 2023 · 3 comments
Open

SVG Icons #48

edjonesdev opened this issue Apr 28, 2023 · 3 comments
Labels
feature New feature or request

Comments

@edjonesdev
Copy link
Owner

I have noticed when using this library in production that font based icons have loads of issues. Internally I have switched to using SVG based icons. There are 2 options:

  1. The next major release replaces font based icons with SVG icons
  2. Create a new library for SVG icons
@edjonesdev edjonesdev added the feature New feature or request label Apr 28, 2023
@mamo-muj
Copy link

Hey @ed-software love the work you've done on this! Any chance of seeing the SVG icons anytime soon? Personally I'd prefer Icons being replaced with SVGIcons but maybe we could create another list to import from the package and do it that way?

So it might look something like react-material-symbols/svg/

@edjonesdev
Copy link
Owner Author

@mamo-muj Thanks for the kind words! I'm still interested in building this feature, but there will be some tough decisions regarding how we should handle the change. If we do end up replacing font-based icons altogether it will have to be on a new major version, since it would break compatibility with the old API. I think the best approach would be to keep font-based icons as an option you can access via something like react-material-symbols/font, since there are still some use cases for the font-based icons that SVGs don't support.

@mamo-muj
Copy link

@ed-software agreed! This makes sense. Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants