Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DER-140 - Wording of the definition of AuctionMethod in CDS is clumsy #1978

Merged
merged 1 commit into from
Dec 3, 2023
Merged

DER-140 - Wording of the definition of AuctionMethod in CDS is clumsy #1978

merged 1 commit into from
Dec 3, 2023

Conversation

ElisaKendall
Copy link
Contributor

Description

Moved the nominal representing auction method from CDS to instrument pricing (it's IRI was for the instrument pricing ontology already) and revised its metadata to simplify the definition and add an explanatory note

Fixes: #1977 / DER-140

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

@ElisaKendall
DER-140 #comment - moved the nominal representing auction method from…
421cba8 
… CDS to instrument pricing (it's IRI was for the instrument pricing ontology already) and revised its metadata to simplify the definition and add an explanatory note

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall added FBC FIBO Financial Business and Commerce DER FIBO Derivatives definition skos:definition issue labels Nov 28, 2023
@ElisaKendall ElisaKendall self-assigned this Nov 28, 2023
@ElisaKendall ElisaKendall merged commit 1520d0f into edmcouncil:master Dec 3, 2023
4 checks passed
@ElisaKendall ElisaKendall deleted the DER-140 branch December 4, 2023 19:37
@mereolog mereolog added this to the 2023Q4 FIBO Release milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfgemski jfgemski jfgemski approved these changes

@tahoeblue tahoeblue tahoeblue approved these changes

@rivettp rivettp Awaiting requested review from rivettp

@mereolog mereolog Awaiting requested review from mereolog

Assignees

@ElisaKendall ElisaKendall

Labels
definition skos:definition issue DER FIBO Derivatives FBC FIBO Financial Business and Commerce
Projects
None yet
Milestone
2023Q4 FIBO Release
Development

Successfully merging this pull request may close these issues.

DER-140 - Wording of the definition of AuctionMethod in CDS is clumsy
4 participants
@ElisaKendall @tahoeblue @jfgemski @mereolog