Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-119 - Need to bring in classification schemes that are used by the SEC and other regulators for classifying shares #1982

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

ElisaKendall
Copy link
Contributor

@ElisaKendall ElisaKendall commented Dec 1, 2023

Description

  1. added the ICB benchmark and scheme managed by FTSE Russell to securities classification
  2. added the GICS classifier (code) and scheme managed by S&P to securities classification

Fixes: #1981 / SEC-119

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

… Russell to securities classification

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall added enhancement SEC FIBO Securities labels Dec 1, 2023
@ElisaKendall ElisaKendall self-assigned this Dec 1, 2023
tahoeblue
tahoeblue previously approved these changes Dec 1, 2023
@mereolog mereolog added this to the 2023Q4 FIBO Release milestone Dec 11, 2023
Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall changed the title SEC-119 - Need to bring in classification schemes that are used by the SEC and other regulators for classifying shares (WIP) SEC-119 - Need to bring in classification schemes that are used by the SEC and other regulators for classifying shares Dec 13, 2023

<owl:NamedIndividual rdf:about="&fibo-sec-sec-cls;GlobalIndustryClassificationStandardsScheme">
<rdf:type rdf:resource="&fibo-fnd-arr-cls;IndustrySectorClassificationScheme"/>
<rdfs:label>Global Industry Classification Standards scheme</rdfs:label>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has a double space between Standards and scheme

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
jfgemski
jfgemski previously approved these changes Dec 13, 2023
Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@rivettp
Copy link
Contributor

rivettp commented Dec 14, 2023

a) are we planning/do we want to have individuals for all the classifications? What about mappings between them?
b) not sure classes such as IndustrySectorClassificationScheme should be specific to FIBO let alone Securities. There are plenty such in broader use e.g. NAICS, SIC, ISIC
c) are these codes also controlled vocabularies that should/could use MVF?

@ElisaKendall ElisaKendall merged commit 699691f into edmcouncil:master Dec 14, 2023
4 checks passed
@ElisaKendall
Copy link
Contributor Author

a) are we planning/do we want to have individuals for all the classifications? What about mappings between them? b) not sure classes such as IndustrySectorClassificationScheme should be specific to FIBO let alone Securities. There are plenty such in broader use e.g. NAICS, SIC, ISIC c) are these codes also controlled vocabularies that should/could use MVF?

@rivettp - we haven't said that we would do that, just include the reference to the scheme at the moment. The classes describing industry sector classification scheme and classifier are in FND. The two included here are specific to securities. Ultimately if we decide to include the reference data, I would want to use Commons/MVF to do that.

@ElisaKendall ElisaKendall deleted the SEC-119 branch December 14, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement SEC FIBO Securities
Projects
None yet
5 participants