Fix to fractional seconds trailing zeros #2029

mereolog · 2024-06-28T08:30:23Z

Description

This removes the fractional second part of xsd:dataTime values as required by the spec.

Fixes: #1993

I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
My contribution follows the principles of best practices for FIBO.
My changes have been reconciled with latest master and no merge conflicts remain.
This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
Hygiene tests have been applied by a PR with "(WIP)" in title.
The issue has been tested locally using a reasoner (for ontology changes).

Signed-off-by: mereolog <pawel.garbacz@makolab.com>

ElisaKendall

This looks fine to me.

fix to fractional seconds trailing zeros

cbf02c7

Signed-off-by: mereolog <pawel.garbacz@makolab.com>

mereolog added this to the 2024Q2 FIBO Release milestone Jun 28, 2024

mereolog self-assigned this Jun 28, 2024

some more fixes to fractional seconds trailing zeros

5025d6b

Signed-off-by: mereolog <pawel.garbacz@makolab.com>

mereolog changed the title ~~Fix to fractional seconds trailing zeros (WIP)~~ Fix to fractional seconds trailing zeros Jun 28, 2024

mereolog marked this pull request as ready for review June 28, 2024 14:40

mereolog requested review from ElisaKendall, jfgemski and rivettp June 28, 2024 14:40

ElisaKendall approved these changes Jun 28, 2024

View reviewed changes

jfgemski approved these changes Jun 28, 2024

View reviewed changes

mereolog merged commit faa996a into master Jun 29, 2024
4 checks passed

mereolog deleted the fix_to_xsddatatime_values branch June 29, 2024 11:10