Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEC-185 - Several terms in the DebtAnalytics ontology should be included in the InstrumentPricing ontology #2034

Merged
merged 4 commits into from
Aug 4, 2024
Merged

SEC-185 - Several terms in the DebtAnalytics ontology should be included in the InstrumentPricing ontology #2034

merged 4 commits into from
Aug 4, 2024

Conversation

ElisaKendall
Copy link
Contributor

@ElisaKendall ElisaKendall commented Jul 26, 2024 •
edited
Loading

Description

  1. Added a definition for accrued interest to the debt ontology and removed it from debt analytics
  2. Moved clean price, dirty price, derived price and related property to the pricing ontology

Fixes: #2033 / SEC-185

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

@ElisaKendall
SEC-185 #comment - added a definition for accrued interest to the deb…
6c6026a 
…t ontology and removed it from debt analytics

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall self-assigned this Jul 26, 2024
@ElisaKendall
SEC-185 #comment - moved clean price, dirty price, derived price and …
569ea36 
…related property to the pricing ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
SEC-185 - cleaned up definitions of clean, dirty, and derived price i…
cd80781 
…n instrument pricing; eliminated redundant elements from debt analytics

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall
SEC-185 - removeed collection of debt pools
f865852 
Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall changed the title SEC-185 - Several terms in the DebtAnalytics ontology should be included in the InstrumentPricing ontology (WIP) SEC-185 - Several terms in the DebtAnalytics ontology should be included in the InstrumentPricing ontology Aug 2, 2024
@ElisaKendall ElisaKendall merged commit f77afe5 into edmcouncil:master Aug 4, 2024
4 checks passed
@ElisaKendall ElisaKendall deleted the SEC-185 branch August 4, 2024 01:07
@mereolog mereolog added this to the 2024Q3 FIBO Release milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfgemski jfgemski jfgemski approved these changes

@tahoeblue tahoeblue tahoeblue approved these changes

Assignees

@ElisaKendall ElisaKendall

Labels
enhancement
Projects
None yet
Milestone
2024Q3 FIBO Release
Development

Successfully merging this pull request may close these issues.

SEC-185 - Several terms in the DebtAnalytics ontology should be included in the InstrumentPricing ontology
4 participants
@ElisaKendall @tahoeblue @jfgemski @mereolog