Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub-2038 - Implicit punning of OWL Classes in triples (as subjects) with datatype property #2048

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

ElisaKendall
Copy link
Contributor

@ElisaKendall ElisaKendall commented Sep 18, 2024

Description

Eliminated the use of hasArgument to refer to certain inputs to various expressions which caused punning, added two properties and refined restrictions to eliminate the obsolete restrictions in the same ontology (GitHub-2028), and normalized language in definitions to eliminate indefinite articles, in compliance with ISO 704

Fixes: #2038

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
… restriction on capitalization-based weighting function

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…improperly and normalized some of the definitions to eliminate indefinite articles at the start of the definition per ISO 704

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…lection of the semantics involved in these cases

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall added bug IND Indices and Indicators domain labels Sep 18, 2024
@ElisaKendall ElisaKendall self-assigned this Sep 18, 2024
…ete' restrictions in the ontology

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…late certain indices

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall changed the title GitHub-2038 - Implicit punning of OWL Classes in triples (as subjects) with datatype property (WIP) GitHub-2038 - Implicit punning of OWL Classes in triples (as subjects) with datatype property Sep 18, 2024
@ElisaKendall ElisaKendall merged commit add02db into edmcouncil:master Sep 18, 2024
4 checks passed
@ElisaKendall ElisaKendall deleted the GitHub-2038 branch September 18, 2024 22:41
@mereolog mereolog added this to the 2024Q3 FIBO Release milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug IND Indices and Indicators domain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit punning of OWL Classes in triples (as subjects) with datatype property
5 participants