Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DER-144 - ForeignExchangeRateObservable incorrectly modeled #2057

Merged
merged 1 commit into from
Sep 20, 2024
Merged

DER-144 - ForeignExchangeRateObservable incorrectly modeled #2057

merged 1 commit into from
Sep 20, 2024

Conversation

ElisaKendall
Copy link
Contributor

Description

Deprecated foreign exchange rate observable given the issues with it and that it was made obsolete by DER-143

Fixes: #2056 / DER-144

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

@ElisaKendall
DER-144 #comment -- deprecated foreign exchange rate observable given…
73edb89 
… the issues with it and that it was made obsolete by DER-143

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall added consistency About overall consistency DER FIBO Derivatives labels Sep 20, 2024
@ElisaKendall ElisaKendall self-assigned this Sep 20, 2024
@ElisaKendall ElisaKendall merged commit 00adeeb into edmcouncil:master Sep 20, 2024
4 checks passed
@mereolog mereolog added this to the 2024Q3 FIBO Release milestone Sep 23, 2024
@ElisaKendall ElisaKendall deleted the DER-144 branch October 14, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfgemski jfgemski jfgemski approved these changes

@rivettp rivettp rivettp approved these changes

@tahoeblue tahoeblue Awaiting requested review from tahoeblue

Assignees

@ElisaKendall ElisaKendall

Labels
consistency About overall consistency DER FIBO Derivatives
Projects
None yet
Milestone
2024Q3 FIBO Release
Development

Successfully merging this pull request may close these issues.

DER-144 - ForeignExchangeRateObservable incorrectly modeled
4 participants
@ElisaKendall @rivettp @jfgemski @mereolog