Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the implementation of the new Aronnax driver and environs #106

Open
3 tasks
axch opened this issue Apr 19, 2017 · 0 comments
Open
3 tasks

Clean up the implementation of the new Aronnax driver and environs #106

axch opened this issue Apr 19, 2017 · 0 comments

Comments

@axch
Copy link
Collaborator

axch commented Apr 19, 2017

There are several things we can do once #101 is merged that will make the resulting code base simpler. We should choose whether and when to.

  • Perhaps replace the driver.data_types dictionary with a dictionary in core, directly holding the generator functions themselves, without indirecting through a string and a chain of if statements for interpreting it.
  • Perhaps move core.fortran_file to the utils module.
  • Perhaps simplify the Fortran core, the parameters.in file, and the inside of the driver by hard-coding a naming convention for the raw input files, since they are now generated anyway.
    • Con: Anyone who wishes to isolate the Fortran core and wrap it differently will have a less flexible object to work with.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant