feat: dont check literal in export declaration

edvardchen · Jul 10, 2019 · 1527eae · 1527eae
1 parent dd279c6
commit 1527eae
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/rules/no-literal-string.js b/lib/rules/no-literal-string.js
@@ -110,6 +110,16 @@ module.exports = {
         visited.push(node);
       },
 
+      'ExportAllDeclaration Literal'(node) {
+        // allow export * from 'mod'
+        visited.push(node);
+      },
+
+      'ExportNamedDeclaration Literal'(node) {
+        // allow export { named } from 'mod'
+        visited.push(node);
+      },
+
       'VariableDeclarator > Literal'(node) {
         // allow statements like const A_B = "test"
         if (isUpperCase(node.parent.id.name)) visited.push(node);

diff --git a/tests/lib/rules/no-literal-string.js b/tests/lib/rules/no-literal-string.js
@@ -30,6 +30,8 @@ ruleTester.run('no-literal-string', rule, {
   valid: [
     { code: 'import("hello")' },
     { code: 'import name from "hello";' },
+    { code: 'export * from "hello_export_all";' },
+    { code: 'export { a } from "hello_export";' },
     { code: 'require("hello");' },
     { code: 'const a = require(["hello"]);' },
     { code: 'const a = require(["hel" + "lo"]);' },