feat: support to access enum value through string like Enum['key']

edvardchen · Apr 17, 2020 · db68147 · db68147
1 parent 5e6dda3
commit db68147
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/rules/no-literal-string.js b/lib/rules/no-literal-string.js
@@ -52,7 +52,7 @@ module.exports = {
     ]
   },
 
-  create: function(context) {
+  create(context) {
     // variables should be defined here
     const {
       parserServices,
@@ -256,6 +256,11 @@ module.exports = {
         visited.add(node);
       },
 
+      'MemberExpression > Literal'(node) {
+        // allow Enum['value']
+        visited.add(node);
+      },
+
       'Literal:exit'(node) {
         // visited and passed linting
         if (visited.has(node)) return;

diff --git a/tests/lib/rules/no-literal-string.js b/tests/lib/rules/no-literal-string.js
@@ -170,6 +170,7 @@ tsTester.run('no-literal-string', rule, {
     { code: `var a: 'abc' = 'abc'` },
     { code: `var a: 'abc' | 'name'  | undefined= 'abc'` },
     { code: "type T = {name: 'b'} ; var a: T =  {name: 'b'}" },
+    { code: "enum T  {howard=1} ; var a = T['howard']" },
     { code: "function Button({ t= 'name'  }: {t: 'name'}){} " },
     { code: "type T ={t?:'name'|'abc'};function Button({t='name'}:T){}" }
   ],