feat: dont check TSLiteralType

edvardchen · Jul 10, 2019 · fd93861 · fd93861
1 parent 57c5066
commit fd93861
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/rules/no-literal-string.js b/lib/rules/no-literal-string.js
@@ -146,6 +146,16 @@ module.exports = {
       },
       // ─────────────────────────────────────────────────────────────────
 
+      //
+      // ─── TYPESCRIPT ──────────────────────────────────────────────────
+      //
+
+      'TSLiteralType Literal'(node) {
+        // allow var a: Type['member'];
+        visited.push(node);
+      },
+      // ─────────────────────────────────────────────────────────────────
+
       'VariableDeclarator > Literal'(node) {
         // allow statements like const A_B = "test"
         if (isUpperCase(node.parent.id.name)) visited.push(node);

diff --git a/tests/lib/rules/no-literal-string.js b/tests/lib/rules/no-literal-string.js
@@ -106,7 +106,15 @@ const tsTester = new RuleTester({
 });
 
 tsTester.run('no-literal-string', rule, {
-  valid: [{ code: '<div className="hello"></div>' }],
+  valid: [
+    { code: '<div className="hello"></div>' },
+    {
+      code: "var a: Element['nodeName']"
+    },
+    {
+      code: "var a: Omit<T, 'af'>"
+    }
+  ],
   invalid: [
     {
       code: `(<button className={styles.btn}>loading</button>)`,