Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore object property name as a string #42

Closed
ivansky opened this issue Mar 18, 2021 · 10 comments · Fixed by #44
Closed

Ignore object property name as a string #42

ivansky opened this issue Mar 18, 2021 · 10 comments · Fixed by #44

Comments

@ivansky
Copy link

ivansky commented Mar 18, 2021

We upgraded to 6 version and the issue appears, is it intended behaviour?
Screenshot 2021-03-18 at 16 25 47

@edvardchen
Copy link
Owner

You can work around this with ignoreProperty option

@ivansky
Copy link
Author

ivansky commented Mar 29, 2021

@edvardchen Is there possibility check Typename of the object and ignore it completely, e.g. SxStyleProp. There is no possibility to ignore everything that is classname string or custom style property.

@bignimbus
Copy link

I think it makes sense to allow developers to ignore all object keys.

Somewhat related: the ability to pass regular expressions to ignore lists would be helpful as well, for this case and others.

@edvardchen
Copy link
Owner

actually ignoreProperty accepts regex @bignimbus

@edvardchen
Copy link
Owner

We upgraded to 6 version and the issue appears, is it intended behaviour?

version 6 of what? eslint? @ivansky

@ivansky
Copy link
Author

ivansky commented Apr 7, 2021

@edvardchen Unfortunately, it doesn't help me to resolve the issue explicitly.
Would it be easier if I make PR with this change or do you have any concerns to ignore some sort of parent types or/and all object keys?

Sorry, regarding version I might take a version from another library mistakenly, probably it was the latest version, it means 5+.

@edvardchen
Copy link
Owner

edvardchen commented Apr 7, 2021 via email

@edvardchen
Copy link
Owner

@ivansky maybe you can try the ignore_object_property_name branch. Help me check if it works

@ivansky
Copy link
Author

ivansky commented Apr 8, 2021

@edvardchen I have tried your ignore_object_property_name branch and it does work for me. Well done!
Will wait for a next version ;)

@edvardchen
Copy link
Owner

try the v5.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants