support eslint 9 #120
Closed
support eslint 9 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`no-literal-string` rule is failing in eslint@9, because few deprecated context methods have been removed (eslint/eslint@ae78ff1). `parserServices` and `getAncestors` methods now live under `context.sourceCode`.
|
@edvardchen, any chance to merge this please? |
|
The changes will break on eslint below v9. Should find the 2 methods under It's weird that the gitlab actions were triggered |
Ah true. I didn't realise, you support older than v8 releases. It should work for v8.44.0 and later though. What do you suggest to do? |
|
I didn't explain clearly. How about const parserServices = context.parserServices || context.sourceCode.parserServicesAnd having some comments around will be nice |
|
closed in favor of #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-literal-stringrule is failing in eslint@9, because few deprecated context methods have been removed (eslint/eslint@ae78ff1).parserServicesandgetAncestorsmethods now live undercontext.sourceCode.