build: tweak dockerfile; build and push both base and dev images #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2021
kdmccormick
force-pushed
the
kdmccormick/docker
branch
2 times, most recently
from
3a4a0f3 to
e33d061
Compare
dockerfile changes:
* rename stages ('app', 'devstack') to ('base', 'dev')
to match edx-platform's Dockerfile.
* add comment to top of dockerfile warnings of its experimental
dev-only state.
* remove newrelic build stage, which doesn't belong in the
core openedx repository.
* in dev stage:
* touch ../credentials_env for devstack compatibility.
* set DJANGO_SETTINGS_MODULE=credentials.settings.devstack.
* set command to a ./manage.py runserver.
kdmccormick
force-pushed
the
kdmccormick/docker
branch
from
e33d061 to
cec2c36
Compare
Tj-Tracy
approved these changes
Dec 23, 2021
|
Thanks for the review TJ! |
|
GitHub Action in this PR is bugged; fixing in #1516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
build: tweak dockerfile; build and push both base and dev images
dockerfile changes:
to match edx-platform's Dockerfile.
dev-only state.
core openedx repository.
Testing instructions
See the testing instructions for the devstack PR.
Supporting information
This is a dependency attempt to use the experimental images in devstack, which itself is part of the effort to move off of edxops DockerHub org images.