Always show active value in ActiveFilters

eea · Feb 3, 2023 · da17feb · da17feb
1 parent f894eb2
commit da17feb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/searchlib/components/Facets/ActiveFilters.jsx b/searchlib/components/Facets/ActiveFilters.jsx
@@ -12,7 +12,8 @@ const ActiveFilters = (props) => {
   const initialValue =
     (filters.find((f) => f.field === field) || {})?.values || [];
 
-  const [activeFilter, setActiveFilter] = React.useState(initialValue);
+  const activeFilter = initialValue;
+  // const [activeFilter, setActiveFilter] = React.useState(initialValue);
 
   return activeFilter.length > 0 ? (
     <div className="active-filters">
@@ -30,10 +31,10 @@ const ActiveFilters = (props) => {
                         className="clear-filters"
                         size="mini"
                         onClick={() => {
-                          let filteredValues = activeFilter.filter(
-                            (v) => v !== option,
-                          );
-                          setActiveFilter(filteredValues);
+                          // let filteredValues = activeFilter.filter(
+                          //   (v) => v !== option,
+                          // );
+                          // // setActiveFilter(filteredValues);
                           onRemove(option);
                         }}
                       >

diff --git a/searchlib/components/Facets/StickyFacetList.jsx b/searchlib/components/Facets/StickyFacetList.jsx
@@ -22,7 +22,7 @@ const SmallScreenFacets = () => {
   return (
     <div>
       <Dimmer active={active} verticalAlign="top" page className="facet-dimmer">
-        {active ? (
+        {active && (
           <>
             <ErrorBoundary>
               <MoreLikeThis />
@@ -36,8 +36,6 @@ const SmallScreenFacets = () => {
               )}
             />
           </>
-        ) : (
-          ''
         )}
 
         <Button.Group>

diff --git a/searchlib/lib/hocs/useWhyDidYouUpdate.js b/searchlib/lib/hocs/useWhyDidYouUpdate.js
@@ -23,6 +23,7 @@ export default function useWhyDidYouUpdate(name, props) {
       });
       // If changesObj not empty then output to console
       if (Object.keys(changesObj).length) {
+        // eslint-disable-next-line no-console
         console.log('[why-did-you-update]', name, changesObj);
       }
     }