Extends FieldArgTypeCoercion #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndresPrez
changed the title
AndresPrez
force-pushed
the
feature/ap/arg-type-better-coercion
branch
from
3302a20 to
b73c68a
Compare
chanind
reviewed
May 26, 2022
|
Hey @chanind, thanks for taking a look at this. Ive fixed the lint issues and your suggestions as well. |
chanind
reviewed
May 29, 2022
|
|
||
| // If no fieldName is provided, check for defined matchConditions. | ||
| // This avoids having to define one rewriter for many fields individually. | ||
| // Alternatively, regex matching for fieldName could be implemented. |
There was a problem hiding this comment.
👍 this is a cool idea for a future PR!
chanind
requested changes
May 29, 2022
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @chanind, here's an extension proposal for the
FieldArgTypeRewriterrewriter.This PR is backwards compatible.
New functionalities are included for the
FieldArgTypeRewriterrewriter.fieldName now optional in case matchConditions are passed: Useful to avoid having to create a new rewriter for every field, as now the matching can be delegated to the matchConditions
coerceVariable function now receives context in second argument: Context includes all of query's variables and arguments, and very useful for coercion that needs the value of other argument values as in pagination coercion (e.g.,
[limit, offset]to[pageSize, pageNumber])In-Query argument values can be coerced: _Now, there's the coerceArgumentValue that allows support when argument values come in the query document.
Unit Tests for new functionalities