Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRAM abstraction does not work for magic drc. #247

Closed
d-m-bailey opened this issue Oct 30, 2023 · 0 comments · Fixed by #248
Closed

SRAM abstraction does not work for magic drc. #247

d-m-bailey opened this issue Oct 30, 2023 · 0 comments · Fixed by #248

Comments

@d-m-bailey
Copy link
Contributor

Looking at files in checks/drc_checks/magic.

The list of used sram modules is passed from python to tcl as a space delimited string ' '.join(sram_modules_in_gds.

    run_magic_drc_check_cmd = ['magic', '-noconsole', '-dnull', '-rcfile', magicrc_file_path, magic_drc_tcl_path, gds_ut_path,
                               design_name, pdk_path, design_magic_drc_file_path, design_magic_drc_mag_file_path,
                               ' '.join(sram_modules_in_gds), esd_fet, has_sram_as_str, has_esd_fet_as_str]

However, the tcl tries to process this as a list.

if { $HAS_SRAM } {
    gds noduplicates yes
    puts "Detected an SRAM module"
    foreach x $SRAM_MODULES {
        puts "Pre-loading a maglef of the SRAM block: ${x}"
        load $PDK_PATH/libs.ref/sky130_sram_macros/maglef/${x}.mag
    }
}

This results in a log file that has

Detected an SRAM module

but no

Pre-loading a maglef of the SRAM block: ...

Changing the string to a list works.

if { $HAS_SRAM } {
    gds noduplicates yes
    puts "Detected an SRAM module"
    foreach x [split $SRAM_MODULES " "] {
        puts "Pre-loading a maglef of the SRAM block: ${x}"
        load $PDK_PATH/libs.ref/sky130_sram_macros/maglef/${x}.mag
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant