From c35225484bd3587d34ee1a8cce677a6a07b21f78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ege=20=C3=87etin?= <64282645+egecetin@users.noreply.github.com> Date: Mon, 4 Sep 2023 22:56:33 +0300 Subject: [PATCH] Set default sanitizers off (#159) --- .github/workflows/build_and_test.yml | 4 ++-- tests/CMakeLists.txt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index 5a050a024..573b2ee0d 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -35,7 +35,7 @@ jobs: - name: Install Test Requirements run: pip install -r tests/data/requirements.txt - name: Configure - run: cmake -DCMAKE_BUILD_TYPE=Debug -DXXX_ENABLE_COVERAGE=ON -DXXX_ENABLE_MEMLEAK_CHECK=ON -DXXX_ENABLE_ASAN=OFF -DXXX_ENABLE_USAN=OFF -S . -B build + run: cmake -DCMAKE_BUILD_TYPE=Debug -DXXX_ENABLE_COVERAGE=ON -DXXX_ENABLE_MEMLEAK_CHECK=ON -S . -B build - name: Build run: cmake --build build --parallel --target coverage-xml - name: Upload to Codecov @@ -66,7 +66,7 @@ jobs: - name: Install Test Requirements run: pip3 install -r tests/data/requirements.txt - name: Configure - run: cmake -DCMAKE_BUILD_TYPE=Release ${{ matrix.additional-flags }} -S . -B build + run: cmake -DCMAKE_BUILD_TYPE=Release -DXXX_ENABLE_ASAN=ON -DXXX_ENABLE_USAN=ON -S . -B build - name: Build run: cmake --build build --parallel - name: Run Tests diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index ddd8991cf..068770d7a 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -10,9 +10,9 @@ endif() configure_file(test-static-definitions.h.in test-static-definitions.h) -option(XXX_ENABLE_ASAN "Enables Address Sanitizer for XXX" ON) +option(XXX_ENABLE_ASAN "Enables Address Sanitizer for XXX" OFF) option(XXX_ENABLE_MSAN "Enables Memory Sanitizer for XXX" OFF) -option(XXX_ENABLE_USAN "Enables Undefined Behaviour Sanitizer for XXX" ON) +option(XXX_ENABLE_USAN "Enables Undefined Behaviour Sanitizer for XXX" OFF) option(XXX_ENABLE_TSAN "Enables Thread Sanitizer for XXX" OFF) # Sanitizers