Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for improving window-status #20

Open
kimsin98 opened this issue Jan 27, 2022 · 3 comments
Open

Suggestions for improving window-status #20

kimsin98 opened this issue Jan 27, 2022 · 3 comments

Comments

@kimsin98
Copy link

  1. Move zoom indicator to index: *Z can be difficult to see after long names. Window indices are consistent and feels like a more natural place for the indicator: #I#{?window_zoomed_flag,*Z,}
  2. Display pane title for current window: Currently, pane title (which may have useful information) is displayed nowhere. Window name in window-status-current-format could be replaced: #W#T
@egel
Copy link
Owner

egel commented Jul 4, 2022

Hi @Aksoo, Bit later, but trying to address your message 😉
Thank you very much for your care and writing down your suggestions 🙌

I to be honest, when reading it I was very curious if the changes can bring something new and I quickly establish a branch with your suggestions (https://github.com/egel/tmux-gruvbox/tree/improving-window-status-from-aksoo) and I tried to compare it with my current configuration from origin/main.

Here is the comparison with my local ZSH config:

origin/main improved-window-status (AKSoo)
Screenshot 2022-07-04 at 23 47 28 Screenshot 2022-07-04 at 23 35 59

I like the changes, although when thinking about it for a few moments, I think proposed changes might break some default tmux expected behaviors (like having *Z right after the name of the running program; just after tmux installation, without custom configs) which some users using tmux might get used to.

Regarding the #W -> #T, in my case, it produced a long text which not fit my subjective taste. I think it's due to the configuration/zsh theme/os I am using.

So I am not quite sure of the proposed changes, and before going with them further, I'd love to get some additional opinions/feedback from others about it 🙂

For the time of gathering feedback, if you need the changes urgently, I would encourage you to fork and roll out your own skin 😉 - it's not complex to do, but rather time-consuming 😆

@egel egel self-assigned this Jul 4, 2022
@kimsin98
Copy link
Author

kimsin98 commented Jul 7, 2022

Both are subjective suggestions that may not fit everyone's use case, so it's totally fine if you don't think they are suitable. I've been using a slightly modified tmux-gruvbox for a while for myself.

@egel
Copy link
Owner

egel commented Jul 13, 2022

What I want to highlight is thank you @Aksoo for your willingness to improve this theme and thank you very much for any ideas. 🙌

In this case, I would like to know some more opinions on whether these modifications will be desirable - for a potential reaction I would give time until the end of the month ie: 31.07.22.
Otherwise, I will want to close this ticket, with the possibility of reopening it in the future if there are more users who want this functionality.

Sidenote: I would like to mention that I am considering the introduction of custom statuses, which could solve the problem of modifying the statuses as the user wishes 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants