EFKeyChain and passing NULL as error

[johankool]

The methods in EFKeyChain accept an **error, but if you're not interested and pass in NULL, this can cause EXC_BAD_ACCESS crashes. The work around is to pass in a NSError pointer anyway.

[ijansch]

isn't it customary to pass in nil, not null, if you're not interested in an error?

On Aug 28, 2012, at 12:35 PM, Johan Kool notifications@github.com wrote:

The methods in EFKeyChain accept an **error, but if you're not interested and pass in NULL, this can cause EXC_BAD_ACCESS crashes. The work around is to pass in a NSError pointer anyway.

—
Reply to this email directly or view it on GitHub.

Ivo Jansch
Egeniq
CEO / Co-founder
ivo@egeniq.com
www.egeniq.com
+31681450625

[johankool]

No: "Always test to see if the parameter is non-NULL before assigning an object to it. And never assign nil to an error parameter."

http://developer.apple.com/library/mac/#documentation/Cocoa/Conceptual/ErrorHandlingCocoa/CreateCustomizeNSError/CreateCustomizeNSError.html#//apple_ref/doc/uid/TP40001806-CH204-SW5

On 29 Aug, 2012, at 00:00, Ivo Jansch notifications@github.com wrote:

isn't it customary to pass in nil, not null, if you're not interested in an error?

On Aug 28, 2012, at 12:35 PM, Johan Kool notifications@github.com wrote:

The methods in EFKeyChain accept an **error, but if you're not interested and pass in NULL, this can cause EXC_BAD_ACCESS crashes. The work around is to pass in a NSError pointer anyway.

—
Reply to this email directly or view it on GitHub.

Ivo Jansch
Egeniq
CEO / Co-founder
ivo@egeniq.com
www.egeniq.com
+31681450625
—
Reply to this email directly or view it on GitHub.