feat: disable espower by default #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@eggjs/tsconfig compile to es2020 by default and espower-source don't support it
|
https://npmmirror.com/package/espower-source 已经失去维护，接下来会直接去掉它。 |
|
忘记 power-assert 吧，有 typings 提示的情况下，有 API 很多也不怕 |
|
v5 先默认改成 false，发个 minor。然后我再提交一个去掉 espower 发 major。 |
任何事情都是有代价，power-assert 理念很好，但是很难长期做下去。 |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 8 -4
Lines 93 60 -33
Branches 16 12 -4
=========================================
- Hits 93 60 -33 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
atian25
pushed a commit
that referenced
this pull request
Dec 18, 2022
[skip ci] ## [5.7.0](v5.6.1...v5.7.0) (2022-12-18) ### Features * disable espower by default ([#196](#196)) ([5e35438](5e35438))
|
🎉 This PR is included in version 5.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fengmk2
added a commit
that referenced
this pull request
Dec 18, 2022
4 tasks
fengmk2
added a commit
that referenced
this pull request
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eggjs/tsconfig compile to es2020 by default and espower-source don't support it
Checklist
npm testpassesAffected core subsystem(s)
Description of change