Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

请问egg-scripts1.x升级到2.x主要变化是什么？ #1733

Closed
logzh opened this issue Nov 24, 2017 · 4 comments · Fixed by eggjs/scripts#16
Closed

请问egg-scripts1.x升级到2.x主要变化是什么？ #1733

logzh opened this issue Nov 24, 2017 · 4 comments · Fixed by eggjs/scripts#16
Assignees
@popomore

Comments

@logzh
Copy link

logzh commented Nov 24, 2017

没有找到egg-scripts1.x升级到2.x的日志或文档。

本人升级app1的egg-scripts到2.x后，使用

egg-scripts stop

停止app1，发现app2（egg-scripts 的版本是1.x）也被停止了。
查看停止日志会发现确实关闭了两个master

[egg-scripts] got master pid ["xxx", "xxxx"]

反之，在app2中关闭应用则不会影响到app1。
@atian25
Copy link
Member

atian25 commented Nov 24, 2017

eggjs/scripts#12

这个 PR 后会关闭所有。@popomore 看看？

@logzh
Copy link
Author

logzh commented Nov 24, 2017

@atian25 谢谢！

@logzh logzh closed this as completed Nov 24, 2017
@atian25 atian25 reopened this Nov 24, 2017
@atian25
Copy link
Member

atian25 commented Nov 24, 2017 via email

@atian25 atian25 mentioned this issue Nov 25, 2017
Merged
4 tasks
@atian25
Copy link
Member

atian25 commented Nov 25, 2017

see eggjs/scripts#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@popomore popomore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support stop --title eggjs/scripts
3 participants
@atian25 @popomore @logzh