feat: siteFile favicon config support function type #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
reviewed
Jan 4, 2023
fengmk2
reviewed
Jan 4, 2023
Codecov ReportBase: 99.85% // Head: 99.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5114 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 35 35
Lines 3483 3485 +2
Branches 510 512 +2
=======================================
+ Hits 3478 3480 +2
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fengmk2
approved these changes
Jan 4, 2023
fengmk2
reviewed
Jan 4, 2023
fengmk2
approved these changes
Jan 4, 2023
atian25
pushed a commit
that referenced
this pull request
Jan 4, 2023
[skip ci] ## [3.12.0](v3.11.1...v3.12.0) (2023-01-04) ### Features * siteFile favicon config support async function type ([#5114](#5114)) ([667684f](667684f))
|
🎉 This PR is included in version 3.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
iblogc
pushed a commit
to iblogc/egg
that referenced
this pull request
Jan 9, 2023
iblogc
pushed a commit
to iblogc/egg
that referenced
this pull request
Jan 9, 2023
[skip ci] ## [3.12.0](eggjs/egg@v3.11.1...v3.12.0) (2023-01-04) ### Features * siteFile favicon config support async function type ([eggjs#5114](eggjs#5114)) ([667684f](eggjs@667684f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
We could use a function to customize favicon config