Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export urllib types #5127

Merged
merged 6 commits into from
Jan 17, 2023
Merged

feat: export urllib types #5127

merged 6 commits into from
Jan 17, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jan 17, 2023

fix cnpm/cnpmcore#370

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 99.85% // Head: 99.85% // No change to project coverage 👍

Coverage data is based on head (6b8247b) compared to base (6c4e8bc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5127   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          35       35           
  Lines        3488     3488           
  Branches      512      512           
=======================================
  Hits         3483     3483           
  Misses          5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2 fengmk2 merged commit 1f7b082 into master Jan 17, 2023
@fengmk2 fengmk2 deleted the export-httpclient-types branch January 17, 2023 12:53
fengmk2 pushed a commit that referenced this pull request Jan 17, 2023
[skip ci]

## [3.14.0](v3.13.0...v3.14.0) (2023-01-17)

### Features

* export urllib types ([#5127](#5127)) ([1f7b082](1f7b082))
@github-actions
Copy link

🎉 This PR is included in version 3.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

iblogc pushed a commit to iblogc/egg that referenced this pull request Mar 13, 2023
iblogc pushed a commit to iblogc/egg that referenced this pull request Mar 13, 2023
[skip ci]

## [3.14.0](eggjs/egg@v3.13.0...v3.14.0) (2023-01-17)

### Features

* export urllib types ([eggjs#5127](eggjs#5127)) ([1f7b082](eggjs@1f7b082))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants