Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-git v5.11.0 inittask panic #28

Closed
TheMightyGit opened this issue Dec 27, 2023 · 5 comments
Closed

go-git v5.11.0 inittask panic #28

TheMightyGit opened this issue Dec 27, 2023 · 5 comments

Comments

@TheMightyGit
Copy link

TheMightyGit commented Dec 27, 2023

Go version: go 1.21.5
MacOS: 12.7 (x86)
goloader: 684a15f

In my outer program I import and use github.com/go-git/go-git/v5 and github.com/go-git/go-git/v5/plumbing (it's a pure go package, no cgo, v5.11.0). These packages are NOT used in my JIT'd code. However, when I use either fmt.Println() or time.Sleep() in the JIT code and I get this panic...

still have 4 unresolved external symbols despite building and linking dependencies...:
github.com/go-git/gcfg/scanner..inittask     required by:
    github.com/go-git/gcfg..inittask

github.com/go-git/gcfg/token..inittask     required by:
    github.com/go-git/gcfg..inittask

github.com/go-git/gcfg/types.EnumParser.Parse     required by:
    github.com/go-git/gcfg.boolSetter

gopkg.in/warnings%2ev0..inittask     required by:
    github.com/go-git/gcfg..inittask

If I remove go-git from my outer code everything is fine.

Happy to provide more details if needed.

@TheMightyGit TheMightyGit changed the title go-git inittask panic go-git v5.11.0 inittask panic Dec 27, 2023
@eh-steve
Copy link
Owner

eh-steve commented Dec 27, 2023

Would you mind trying on this branch #27 ?

I'm also planning to do some major rework soon which should hopefully fix some of these issues.

@TheMightyGit
Copy link
Author

@eh-steve Yes! That fixes it :)

@eh-steve
Copy link
Owner

Great, I just need to massage the CI on that PR before I merge it so there might be some rebases before it ends up in master.

@eh-steve
Copy link
Owner

eh-steve commented Jan 2, 2024

Merged into master, let me know if it works for you and I'll close this issue

@TheMightyGit
Copy link
Author

Merged into master, let me know if it works for you and I'll close this issue

@eh-steve It works for me on master now. Thank you! :)

@eh-steve eh-steve closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants