Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a state for manage loaders, untill images are not ready to use #3

Open
Muhammad-zain-rehman opened this issue Jun 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Muhammad-zain-rehman
Copy link

Hey! Ehsan thanks for sharing such a nice library it made my day. let me tell you a little bit of enhancement for this library that should be considered. As I'm a beginner it might be helpful for me as well.

Although it is amazing, there should be a prop that can tell us about the loading state of the images. For example, I just use this library in my project it has 400 images for one sequence, When images are loaded by the library meanwhile my screen gets blank. I'm not quite sure how I can handle this but I think whenever the images are (e.g. first image of any sequence) being loaded by the library there should be a prop through which we/I can determine and manage any loader kinda stuff.

~Regards

@ehsan-shv
Copy link
Owner

Hi Muhammad! Yeah, you're right. I have a plan to refactor it in the future. Maybe I can handle it. Meanwhile, if you have any ideas feel free to create MR

@ehsan-shv ehsan-shv added the enhancement New feature or request label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants