From c2491a14b83baeb58c77c582b58e21fdbc149f9d Mon Sep 17 00:00:00 2001 From: Colin Ihrig Date: Mon, 15 Jul 2024 13:10:01 -0400 Subject: [PATCH] test_runner: remove plan option from run() This commit removes the plan option to run(). I believe it was added by mistake. It is not documented, untested, and a test plan does not make sense in the context of run(). This commit also fixes a minor formatting issue in a related fixture. Refs: https://github.com/nodejs/node/pull/52860 PR-URL: https://github.com/nodejs/node/pull/53834 Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell Reviewed-By: Marco Ippolito Reviewed-By: Moshe Atlow --- lib/internal/test_runner/runner.js | 3 +-- test/fixtures/test-runner/output/test-runner-plan.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/internal/test_runner/runner.js b/lib/internal/test_runner/runner.js index c625024d4260f8..6fd1cb72f3b508 100644 --- a/lib/internal/test_runner/runner.js +++ b/lib/internal/test_runner/runner.js @@ -483,7 +483,6 @@ function run(options = kEmptyObject) { watch, setup, only, - plan, } = options; if (files != null) { @@ -552,7 +551,7 @@ function run(options = kEmptyObject) { }); } - const root = createTestTree({ __proto__: null, concurrency, timeout, signal, plan }); + const root = createTestTree({ __proto__: null, concurrency, timeout, signal }); root.harness.shouldColorizeTestFiles ||= shouldColorizeTestFiles(root); if (process.env.NODE_TEST_CONTEXT !== undefined) { diff --git a/test/fixtures/test-runner/output/test-runner-plan.js b/test/fixtures/test-runner/output/test-runner-plan.js index 0d6cc8ed05cdd8..2f4cce48d54fd5 100644 --- a/test/fixtures/test-runner/output/test-runner-plan.js +++ b/test/fixtures/test-runner/output/test-runner-plan.js @@ -74,6 +74,6 @@ test('planning with streams', (t, done) => { }); stream.on('end', () => { - done(); + done(); }); })