Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Unbuildable by F-Droid #178

Closed
gsantner opened this issue Apr 8, 2018 · 3 comments
Closed

Unbuildable by F-Droid #178

gsantner opened this issue Apr 8, 2018 · 3 comments
Assignees

Comments

@gsantner
Copy link

gsantner commented Apr 8, 2018

Hi there, I saw that recently a jar was checked in (for ssh module). This makes the app unbuildable by F-Droid as they only allow to build from source or from mvm repos that provide the source for the jar together with the jar.

Is there any way the jar could be removed and instead the lib be loaded from e.g. mavencentral or jitpack? Should be easy possible, ala compile 'com.hierynomus:sshj:0.25.0' - see https://search.maven.org/#artifactdetails%7Ccom.hierynomus%7Csshj%7C0.25.0%7Cjar for other versions

Btw, F-Droid is currently on the state of 1.8.0, don't know what happened since that. https://gitlab.com/fdroid/fdroiddata/blob/master/metadata/de.eidottermihi.raspicheck.txt

Thank you!

@eidottermihi eidottermihi self-assigned this Apr 9, 2018
@eidottermihi
Copy link
Owner

Thanks for reminding, the jar was a temporarily workaround for as long as sshj version >= 0.24 wasn't released. As this is no longer the case, I will switch to the official release (and will look into F-Droid metadata).

@eidottermihi
Copy link
Owner

fixed in 0e76097, v1.8.10

@PanderMusubi
Copy link
Contributor

@eidottermihi see #195 for metadata

Other question, see can you add versionName as is mentioned in https://gitlab.com/fdroid/fdroiddata/-/issues/1988#note_311073711 so that F-Droid can build new releases automatically?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants