Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share type refactor #439

Open
fl0rek opened this issue Oct 11, 2024 · 0 comments
Open

Share type refactor #439

fl0rek opened this issue Oct 11, 2024 · 0 comments

Comments

@fl0rek
Copy link
Member

fl0rek commented Oct 11, 2024

Share type refactor - when we introduced our Share type, we required it to have a validated namespace. In retrospect this might not have been a right decision, as all parity shares are treated as if they had PARITY_NAMESPACE, despite the actual value being random bytes coming from leopard codec. This meant that wherever share could be a parity share we couldn't use our typed interface and had to fall back to plain vectors of bytes with custom logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant