Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] Format chapter number to %03d #22

Closed
kuanyui opened this issue Oct 30, 2016 · 4 comments
Closed

[suggestion] Format chapter number to %03d #22

kuanyui opened this issue Oct 30, 2016 · 4 comments

Comments

@kuanyui
Copy link
Contributor

kuanyui commented Oct 30, 2016

For sorting.
@eight04
Copy link
Owner

eight04 commented Oct 30, 2016

Comic Crawler doesn't know the chapter number but the title (although it contains the chapter number in most cases). It is hard to extract chapter number from the title.

It would be better to format the title str in site modules, but I doubt if we should do that since the title is directly grabbed from the web page.

@kuanyui
Copy link
Contributor Author

kuanyui commented Oct 31, 2016 •
edited
Loading

I've ever done exactly this thing in my (outdated...Q_Q, so your project saves me) crawler for dm5.

Match 第(\d+?)[话卷], if found, format the grouped number to %03d; otherwise, just ignore it.

@eight04
Copy link
Owner

eight04 commented Oct 31, 2016

👍
Would you like to send a PR for this?
https://github.com/eight04/ComicCrawler/blob/master/comiccrawler/mods/dm5.py#L34

@kuanyui kuanyui mentioned this issue Jan 4, 2017
Merged
@eight04
Copy link
Owner

eight04 commented Jan 5, 2017

Fixed in 2017.1.6.

@eight04 eight04 closed this as completed Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eight04 @kuanyui