Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minify dist file #14

Closed
ericmdantas opened this issue Jan 13, 2016 · 5 comments
Closed

Minify dist file #14

ericmdantas opened this issue Jan 13, 2016 · 5 comments

Comments

@ericmdantas
Copy link

Is there any specific reason not to minify dist/datime.js?

If you guys want it, I can send a PR to do it.

Great module, by the way.
@eight04
Copy link
Owner

eight04 commented Jan 14, 2016

I think it's not that necessary to minify them because most of the developers have their own build tool, which not only minify js but concat each modules into one js file.

@ericmdantas
Copy link
Author

Well, we could have both files, actually. A minified and a not minified one - which is pretty common.

But that's up to you.

@eight04
Copy link
Owner

eight04 commented Jan 16, 2016

It is good to have both 👍

@ericmdantas
Copy link
Author

I'll send a PR soon.

@eight04 eight04 mentioned this issue Sep 16, 2017
Merged
@eight04
Copy link
Owner

eight04 commented Sep 16, 2017

Fixed in 5.2.0.

@eight04 eight04 closed this as completed Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eight04 @ericmdantas