feat: Gather metrics from sinks #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
approved these changes
Jul 6, 2020
|
Perhaps another label could be used to help differentiate the |
|
@digitalsadhu Good point. I've now made it so that there is a |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 7, 2020
# [1.1.0](v1.0.4...v1.1.0) (2020-07-07) ### Features * Gather metrics from sinks ([#148](#148)) ([7d1792c](7d1792c))
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds metrics to the internal sinks. These metrics ups a counter for each method in the sink where the method is set as a label on the counter. If the value to the arguments passed to the method is not valid or a directory traversal is tried, the counter will have a
successlabel set tofalse. If the method touches the storage, thesuccesslabel will be set totrue.Do note that if writing to the storage fails (ex a permission is not granted etc), the metric will have
successset totrue. This is because we would like to distinguish between touching the file storage (successistrue) and when we are not touching the file storage (successisfalse). These are handy to distinguish on when writing / reading to cloud storages where one pay for access operations.