Check for existing import-map and npm package before POSTing og PUTing alias #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great :) I was just looking into the service module. You might wonder why there is a core and service module and the reason for this is that we at one point would like to provide Eik as a standalone service which can run in a container but also be able to run the server side part of Eik on ex AWS lambda or GCS cloud functions. |
|
lgtm 👍 |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 12, 2021
## [1.2.25](v1.2.24...v1.2.25) (2021-10-12) ### Bug Fixes * Check for existing import-map and npm package before POSTing og PUTing alias ([#277](#277)) ([a6c65ef](a6c65ef))
|
🎉 This PR is included in version 1.2.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow up on #276, I realised forgot to take into account that aliases can be made for npm scoped packages and import-maps as well. Sorry about that 😅
This PR handles logic for both these types as well as tests for existing npm packages and import-maps.
The source has been tested locally together with the service repository. After this PR is merged and released it should be a breeze to make a new releases of
@eik/serviceand@eik/cli😃