Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swallow error messages when the stream is closed. #58

Closed
wants to merge 1 commit into from

Conversation

alexrudy
Copy link

This is a fix for #43 as suggested in the comments.

I didn't remove the closing() context manager, doesn't seem necessary, as just swallowing the error should be enough.

This does point out that pytest-catchlog could do something smarter in .handleError() and report that back in the pytest results.

@alexrudy alexrudy closed this May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant