feat: added customization options for Window Titles + ... #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed AppearanceView.swift reference from project root
Renamed view structures to be consistent
add several more options for Window Title settings: - Enable/disable - Show in Window Switcher, Dock Previews, or Always
Updates verbiage used for various appearance settings for clarification
chrisharper22
changed the title
|
Also, should proper string keys be considered? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds customization options for Window Titles: where they are shown and if shown at all.
Second, this PR renames the views for Settings in order to create consistency.
Additionally, this PR addresses some verbiage changes that I believe add clarification to what they do. (Note: on existing string keys, I only updated the English locale to prevent breaking other locales; this should either be updated in all locales or have the direct key(s) changed as well.)
Edit: also, apologizes — this PR contains multiple scopes: feature additions & minor code refactoring.