Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper string keys #129

Closed
ejbills opened this issue Jul 10, 2024 · 6 comments
Closed

Proper string keys #129

ejbills opened this issue Jul 10, 2024 · 6 comments

Comments

@ejbills
Copy link
Owner

ejbills commented Jul 10, 2024

          Also, should proper string keys be considered?

Originally posted by @chrisharper22 in #128 (comment)

Localization should have proper string keys.

@ShlomoCode
Copy link
Contributor

ShlomoCode commented Jul 10, 2024

If the string is too general, comment can be used to display additional information.
Do we really want that overhead of keys?

@ejbills ejbills closed this as completed Jul 10, 2024
@ejbills ejbills closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
@chrisharper22
Copy link
Contributor

Was this closed by accident, or are string keys not on the to do list?

@ejbills
Copy link
Owner Author

ejbills commented Jul 11, 2024

Well, doesn't crowdin solve this essentially? Or do you still recommend string keys?

@chrisharper22
Copy link
Contributor

Well, doesn't crowdin solve this essentially? Or do you still recommend string keys?

Oh, to be honest I've never looked into what Crowdin provides, nor looked at the recent PRs involving it. If it is sufficient for localization then forget I commented here! Totally my bad.

@ShlomoCode
Copy link
Contributor

ShlomoCode commented Jul 11, 2024

Crowdin has a smart dictionary feature that brings up similar strings as suggestions.
From my experience translating the iina app through Crowdin it's really good, and I think it may solve the problem of translations that are reset due to a small change in the source string, because in such a case Crowdin knew how to offer the previous translation, and in one click save it again.

@chrisharper22
Copy link
Contributor

Crowdin has a smart dictionary feature that brings up similar strings as suggestions. From my experience translating the iina app through Crowdin is really good, and I think it may solve the problem of translations that are reset due to a small change in the source string, because in such a case Crowdin knew how to offer the previous translation, and in one click save it again.

Perfect, thanks for explaining it! Never mind me bringing up this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants