fix stuttering on profiles

ejbills · Jan 9, 2024 · 3db4089 · 3db4089
1 parent 43058e3
commit 3db4089
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 23 deletions.
diff --git a/...proj/project.xcworkspace/xcuserdata/ethanbills.xcuserdatad/UserInterfaceState.xcuserstate b/...proj/project.xcworkspace/xcuserdata/ethanbills.xcuserdatad/UserInterfaceState.xcuserstate
diff --git a/OpenArtemis/Views/Profiles/ProfileView.swift b/OpenArtemis/Views/Profiles/ProfileView.swift
@@ -45,12 +45,16 @@ struct ProfileView: View {
                     readPosts: readPosts,
                     savedPosts: savedPosts,
                     savedComments: savedComments,
-                    appTheme: appTheme,
-                    onListElementAppearance: { media in
-                        handleMediaAppearance(MiscUtils.extractMediaId(from: media))
-                    }
+                    appTheme: appTheme
                 )
 
+                Rectangle()
+                    .fill(Color.clear)
+                    .frame(height: 1)
+                    .onAppear {
+                        scrapeProfile(lastPostAfter, sort: filterType)
+                    }
+
                 if isLoading { // show spinner at the bottom of the feed
                     HStack {
                         Spacer()
@@ -124,21 +128,4 @@ struct ProfileView: View {
 
         scrapeProfile()
     }
-
-    private func handleMediaAppearance(_ mediaId: String) {
-        guard mixedMedia.count > 0 else {
-            return
-        }
-
-        let index = Int(Double(mixedMedia.count) * 0.85)
-        guard index < mixedMedia.count else {
-            return
-        }
-
-        let tempMediaId = MiscUtils.extractMediaId(from: mixedMedia[index])
-
-        if mediaId == tempMediaId {
-            scrapeProfile(lastPostAfter, sort: filterType)
-        }
-    }
 }
diff --git a/OpenArtemis/Views/Search/SearchView.swift b/OpenArtemis/Views/Search/SearchView.swift
@@ -70,7 +70,7 @@ struct SearchView: View {
                             readPosts: readPosts,
                             savedPosts: savedPosts,
                             appTheme: appTheme,
-                            preventDivider: true
+                            preventDivider: isSubredditSearch
                         )
                     }
                 } else {

diff --git a/OpenArtemis/Views/Subreddits/SubredditFeedView.swift b/OpenArtemis/Views/Subreddits/SubredditFeedView.swift
@@ -108,7 +108,8 @@ struct SubredditFeedView: View {
         .refreshable {
             clearFeedAndReload()
         }
-        .onChange(of: subredditName) { _, _ in // this handles a navsplitview edge case where swiftui reuses the initial view from the sidebar selection.
+        .onChange(of: subredditName) { _, _ in // this handles a navsplitview edge case where swiftui 
+                                               // reuses the initial view from the sidebar selection.
             clearFeedAndReload()
         }
         .searchable(text: $searchTerm, prompt: "Search r/\((titleOverride != nil) ? titleOverride! : subredditName)")

diff --git a/OpenArtemis/Views/Themes/Theme Wrappers.swift b/OpenArtemis/Views/Themes/Theme Wrappers.swift
@@ -28,6 +28,7 @@ struct ThemedList<Content: View>: View {
                         .listRowSeparator(.hidden)
                 }
                 .scrollContentBackground(.hidden)
+                .listStyle(.plain)
                 .environment(\.defaultMinListRowHeight, 0)
             } else {
                 List {