Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug, 1.20.1]: Villager Hats compat causing clients to disconnect on servers #244

Open
NovelPhacelia opened this issue Jul 28, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@NovelPhacelia
Copy link

What happened?

Clients disconnect from server when bounties update with villager hats, Villager Hats version 1.6.1

How can we reproduce it?

  1. Join a server with Villager Hat and Bountiful (This don't work on client, but still outputs logs)
  2. Go to a village

Mod Version

6.0.3

Mod Loader

Fabric

Mod Loader Version

0.86.0

Relevant log output

latest.log
[16:24:25] [Server thread/WARN]: Bountiful reward pool entry is not valid!: all_rew_villager_hats_random_hat
[16:24:25] [Server thread/WARN]: Bounty Pool Entry Invalid: (all_rew_villager_hats_random_hat - #villager-hats:hats) details: {
"type": "minecraft:item_tag",
"rarity": "RARE",
"content": "#villager-hats:hats",
"name": null,
"icon": null,
"amount": {
"min": 1,
"max": 1
},
"unitWorth": 2000.0,
"weightMult": 0.009090909090909092,
"timeMult": 1.0,
"repRequired": 0.0,
"forbids": [
],
"conditions": null,
"mystery": false,
"nbt": null
}

@NovelPhacelia NovelPhacelia added the bug Something isn't working label Jul 28, 2023
@ejektaflex
Copy link
Owner

Interesting - do you have a client version of this log? This simply contains warnings and no crash; it could be a recursive loop timing out, but I don't see any sort of recursive stack limit being reached.

@ejektaflex ejektaflex added the needs response This issue is waiting for a response before action can be taken. label Jul 28, 2023
@NovelPhacelia
Copy link
Author

latest.log
Tried it with the full list of mods and got the same result, it only disconnects me on servers but the server itself never crashes

@ejektaflex
Copy link
Owner

For now, you can disable the Villager Hats compat datapack by running this on the server:
/datapack disable "bountiful:compat-villager-hats"
I hope that helps!

@NovelPhacelia
Copy link
Author

Thanks! I'll try this

@ejektaflex ejektaflex removed the needs response This issue is waiting for a response before action can be taken. label Jul 30, 2023
@viktordimov
Copy link

It also happens on single player worlds, causing "invalid player data" error

@ejektaflex ejektaflex changed the title [Bug]: Villager Hats compat causing clients to disconnect on servers [Bug, 1.20.1]: Villager Hats compat causing clients to disconnect on servers Mar 15, 2024
@ejektaflex ejektaflex moved this to Todo Next Release in Bountiful May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo Next Release
Development

No branches or pull requests

3 participants