Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language problem #300

Open
NeoStarWonV opened this issue Oct 11, 2024 · 3 comments
Open

language problem #300

NeoStarWonV opened this issue Oct 11, 2024 · 3 comments
Assignees
@ejektaflex
Labels
bug Something isn't working

Comments

@NeoStarWonV
Copy link

What happened?

it is not working when I try to translate bounty rarity into Chinese.Is there a problem in the language code?

How can we reproduce it?

No response

Mod Version

1.20.1

Mod Loader

Forge

Mod Loader Version

47.3.1

Relevant log output

No response
@NeoStarWonV NeoStarWonV added the bug Something isn't working label Oct 11, 2024
@NeoStarWonV
Copy link
Author

image

@ejektaflex
Copy link
Owner

Seems to be two things:

Bountiful/common/src/main/java/io/ejekta/bountiful/content/BountyItem.kt

Line 27 in 971b7a2

if (it.isLowerCase()) it.titlecase(Locale.getDefault()) else it.toString()

It might be Locale.getDefault there. Additionally, we should not be hardcoding "Bounty" in after the rarity. Something to fix for the future. Thanks!

@NeoStarWonV
Copy link
Author

ok,thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ejektaflex ejektaflex

Labels
bug Something isn't working
Projects
Bountiful
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejektaflex @NeoStarWonV