Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Ensure isolation of Yojson wrt to Flèche #514

Open
ejgallego opened this issue Jun 26, 2023 · 0 comments
Open

[build] Ensure isolation of Yojson wrt to Flèche #514

ejgallego opened this issue Jun 26, 2023 · 0 comments
Labels
kind: bug Something isn't working
Milestone

Comments

@ejgallego
Copy link
Owner

As of today, we want to ensure Flèche remains transport agnostic, however due to fleche_waterproof Yojson is in scope so that can be a bit tricky to ensure as we can pass some callback that expects LSP messages as we did before #513

There are two ways to fix this:

  • use (implicit_transitive_deps false), but that doesn't work well at all I think
  • make Fleche_waterproof register with Flèche, but this adds some overhead.
@ejgallego ejgallego added the kind: bug Something isn't working label Jun 26, 2023
@ejgallego ejgallego added this to the 0.2.0 milestone May 2, 2024
@ejgallego ejgallego modified the milestones: 0.2.0, 0.2.1 Jun 8, 2024
@ejgallego ejgallego modified the milestones: 0.2.1, 0.2.2 Aug 29, 2024
@ejgallego ejgallego modified the milestones: 0.2.3, 0.2.4 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant