Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MLP and vanilla RNN model definitions to the neural_verification module #1

Open
ejmichaud opened this issue Sep 14, 2023 · 1 comment
Open

Add MLP and vanilla RNN model definitions to the neural_verification module #1

ejmichaud opened this issue Sep 14, 2023 · 1 comment
Assignees
@ejmichaud @KindXiaoming
Labels
enhancement New feature or request

Comments

@ejmichaud
Copy link
Owner

For the sake of consistency, it would be good if MLP and RNN model definitions were added to the neural_verification module. This would make them easily importable in people's scripts for their respective tasks.
@ejmichaud ejmichaud added the enhancement New feature or request label Sep 14, 2023
@ejmichaud
Copy link
Owner Author

We should also define dataclass objects for MLP and RNN architectures like is done for GPTConfig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ejmichaud ejmichaud

@KindXiaoming KindXiaoming

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejmichaud @KindXiaoming