Skip to content

Commit

Permalink
core: Disable panic mode
Browse files Browse the repository at this point in the history
It is now discovering legitimate errors in some tests that need to be
resolved first. Follow progress at grpc#3293.
  • Loading branch information
ejona86 committed Feb 27, 2018
1 parent ce84c2b commit 4a5b8d6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
6 changes: 5 additions & 1 deletion core/src/main/java/io/grpc/internal/ManagedChannelImpl.java
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ final class ManagedChannelImpl extends ManagedChannel implements Instrumented<Ch
@Override
void handleUncaughtThrowable(Throwable t) {
super.handleUncaughtThrowable(t);
panic(t);
// Disabled because it breaks some tests, as it detects pre-existing issues.
// See #3293
if (false) {
panic(t);
}
}
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@
import java.util.concurrent.atomic.AtomicLong;
import javax.annotation.Nullable;
import org.junit.After;
import org.junit.Assume;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
Expand Down Expand Up @@ -1666,6 +1667,8 @@ public void panic_bufferedCallsWillFail() {
}

private void verifyPanicMode(Throwable cause) {
Assume.assumeTrue("Panic mode disabled to resolve issues with some tests. See #3293", false);

@SuppressWarnings("unchecked")
ClientCall.Listener<Integer> mockListener =
(ClientCall.Listener<Integer>) mock(ClientCall.Listener.class);
Expand Down

0 comments on commit 4a5b8d6

Please sign in to comment.