Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] replace console logs with logger #348

Open
marcoreni opened this issue Feb 17, 2021 · 1 comment
Open

[Feature] replace console logs with logger #348

marcoreni opened this issue Feb 17, 2021 · 1 comment
Labels

Comments

@marcoreni
Copy link
Contributor

Is your feature request related to a problem? Please describe.
After #337, some references to console.warn are still in the codebase:

It should be useful to switch to a logger implementation entirely.

Describe the solution you'd like
1- Pass a logger inside the options, that defaults to console. (for backwards compatibility),
2- AND/OR allow to pass a custom "handleError" function as an option, so that we can customize the handling of internal errors.

@derduher
Copy link
Collaborator

Thanks for your PR. I've merged and released it. It looks like validator's console.warn still needs to be handled. I'll take a look at that tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants