hierarchy: Increase ScopeRef size

[hovind]

I run into some issues with

wellen/wellen/src/hierarchy.rs

Line 1030 in 713b1a0

let wrapped_id = HierarchyItemId::Scope(ScopeRef::from_index(node_id).unwrap());

panic()-ing on VCDs generated by gatelist simulations.

I don't know if that's a use case that you want to support, but I figured I should share my experience either way. Thanks for the great library!

[ekiwi]

Thanks! This seems very reasonable. I am often a bit too conservative.

[ekiwi]

This enhancement is part of v0.11.1 which I just pushed to crates: https://crates.io/crates/wellen
Thanks!

[hovind]

This enhancement is part of v0.11.1 which I just pushed to crates: https://crates.io/crates/wellen Thanks!

Thanks for looking at this so quickly. It seems I failed to consider test_sizes() in hierarchy.rs, pushed a proposal to b3afbdd, but I defer to your judgement.

[ekiwi]

It seems I failed to consider test_sizes() in hierarchy.rs, pushed a proposal to b3afbdd, but I defer to your judgement.

Those tests are extremely brittle, so no worries about missing them. I merged your commit and then added a fix for the tests on top of it before publishing the new version:
2cb866d

[ekiwi]

Are you using wellen as part of Surfer? If so, you might want to make a PR on the Surfer repo to bump the underlying wellen version.

[hovind]

Are you using wellen as part of Surfer? If so, you might want to make a PR on the Surfer repo to bump the underlying wellen version.

I do indeed, good idea! Brushed some dust off my Gitlab account: https://gitlab.com/surfer-project/surfer/-/merge_requests/480.